fix: return self for classmethods of roborockmodeenum #720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves type checking for the RoborockModeEnum class by replacing explicit RoborockModeEnum return type annotations with Self. This allows type checkers to correctly infer that subclasses of RoborockModeEnum return their own type rather than the base class type.
Key changes:
- Added
Selfimport from thetypingmodule - Updated return type annotations for
__new__,from_code,from_value, andfrom_namemethods to useSelf
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
allenporter
approved these changes
Dec 29, 2025
Contributor
allenporter
left a comment
allenporter
left a comment
There was a problem hiding this comment.
Thanks for fixing this. I had the impression this required a newer version of python but maybe i'm mixing it up with another feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows type checkers to understand the proper typing of the object.